Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Migrate][Test] Add Spotless step to check and block jUnit4 imports #12398

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

EricGao888
Copy link
Member

Purpose of the pull request

Brief change log

  • Add Spotless step to check and block jUnit4 imports

Verify this pull request

  • Tested manually.

@EricGao888 EricGao888 added improvement make more easy to user or prompt friendly test CI&CD labels Oct 17, 2022
@EricGao888 EricGao888 added this to the 3.2.0 milestone Oct 17, 2022
@EricGao888 EricGao888 self-assigned this Oct 17, 2022
@EricGao888 EricGao888 marked this pull request as ready for review October 17, 2022 05:33
@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2022

Codecov Report

Merging #12398 (c95bd8a) into dev (b7bd8d7) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head c95bd8a differs from pull request most recent head 4ff8912. Consider uploading reports for the commit 4ff8912 to get more accurate results

@@             Coverage Diff              @@
##                dev   #12398      +/-   ##
============================================
- Coverage     38.93%   38.92%   -0.01%     
+ Complexity     4178     4175       -3     
============================================
  Files          1040     1040              
  Lines         38805    38796       -9     
  Branches       4460     4460              
============================================
- Hits          15107    15100       -7     
  Misses        21930    21930              
+ Partials       1768     1766       -2     
Impacted Files Coverage Δ
.../org/apache/dolphinscheduler/api/enums/Status.java 100.00% <ø> (ø)
...api/service/impl/ProcessDefinitionServiceImpl.java 34.85% <ø> (+0.13%) ⬆️
...olphinscheduler/plugin/task/api/TaskConstants.java 0.00% <ø> (ø)
...erver/master/processor/queue/TaskEventService.java 69.64% <0.00%> (-10.72%) ⬇️
...r/plugin/task/sqoop/parameter/SqoopParameters.java 55.12% <0.00%> (-1.29%) ⬇️
...pache/dolphinscheduler/common/utils/DateUtils.java 74.54% <0.00%> (+0.60%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Oct 17, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kezhenxu94 kezhenxu94 merged commit c7e6e82 into apache:dev Oct 17, 2022
Chris-Arith pushed a commit to Chris-Arith/dolphinscheduler that referenced this pull request Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement make more easy to user or prompt friendly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Migrate][Test] Block explicit import of jUnit 4 library
3 participants