[Improvement][Test] Migrate all UT cases from jUnit4 to jUnit5 in task-plugin module as an example #12299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricGao888
changed the title
EricGao888
requested review from
caishunfeng,
SbloodyS and
zhuangchong
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...maker/src/test/java/org/apache/dolphinscheduler/plugin/task/sagemaker/SagemakerTaskTest.java
Fixed
Show fixed
Hide fixed
...maker/src/test/java/org/apache/dolphinscheduler/plugin/task/sagemaker/SagemakerTaskTest.java
Fixed
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## dev #12299 +/- ##
============================================
+ Coverage 38.53% 38.58% +0.04%
- Complexity 4075 4101 +26
============================================
Files 1023 1031 +8
Lines 38267 38458 +191
Branches 4393 4402 +9
============================================
+ Hits 14748 14840 +92
- Misses 21796 21889 +93
- Partials 1723 1729 +6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
11 tasks
|
Kudos, SonarCloud Quality Gate passed!
|
kezhenxu94
approved these changes
Oct 11, 2022
xdu-chenrj
pushed a commit
to xdu-chenrj/dolphinscheduler
that referenced
this pull request
Oct 13, 2022
…k-plugin module as an example (apache#12299) * Migrate all UT cases from jUnit4 to jUnit5 in task-plugin module as an example
fuchanghai
pushed a commit
to fuchanghai/dolphinscheduler
that referenced
this pull request
Nov 16, 2022
…k-plugin module as an example (apache#12299) * Migrate all UT cases from jUnit4 to jUnit5 in task-plugin module as an example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Brief change log
Verify this pull request