Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement][Test] Remove powermock in service and server modules #12164

Merged
merged 5 commits into from
Sep 29, 2022
Merged

[Improvement][Test] Remove powermock in service and server modules #12164

merged 5 commits into from
Sep 29, 2022

Conversation

EricGao888
Copy link
Member

Purpose of the pull request

Brief change log

  • Remove Powermock in dolphinscheduler-service and dolphinscheduler-server modules.
  • Refactor some related code to decouple instantiation from constructor.

Verify this pull request

  • Verified by unit tests.

@EricGao888 EricGao888 self-assigned this Sep 27, 2022
@EricGao888 EricGao888 added improvement make more easy to user or prompt friendly backend test labels Sep 27, 2022
@EricGao888 EricGao888 added this to the 3.2.0 milestone Sep 27, 2022
@EricGao888 EricGao888 marked this pull request as ready for review September 27, 2022 08:46
@EricGao888 EricGao888 changed the title Remove powermock in service and server modules [Improvement][Test] Remove powermock in service and server modules Sep 27, 2022
@github-actions github-actions bot removed the test label Sep 27, 2022
@sonarcloud
Copy link

sonarcloud bot commented Sep 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

66.7% 66.7% Coverage
0.0% 0.0% Duplication

@EricGao888 EricGao888 merged commit d1e409e into apache:dev Sep 29, 2022
xdu-chenrj pushed a commit to xdu-chenrj/dolphinscheduler that referenced this pull request Oct 13, 2022
@EricGao888 @xdu-chenrj
[Improvement][Test] Remove powermock in service and server modules (a…
4402567 
…pache#12164)

* Remove powermock and refactor some related code in dolphinscheduler-service and dolphinscheduler-server modules
* Remove redundant comments
* Add null check
fuchanghai pushed a commit to fuchanghai/dolphinscheduler that referenced this pull request Nov 16, 2022
@EricGao888
[Improvement][Test] Remove powermock in service and server modules (a…
a2ca5d9 
…pache#12164)

* Remove powermock and refactor some related code in dolphinscheduler-service and dolphinscheduler-server modules
* Remove redundant comments
* Add null check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kezhenxu94 kezhenxu94 kezhenxu94 approved these changes

@caishunfeng caishunfeng Awaiting requested review from caishunfeng caishunfeng is a code owner

Assignees

@EricGao888 EricGao888

Labels
backend improvement make more easy to user or prompt friendly
Projects
None yet
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.

[Improvement][Test] Remove Powermock in dolphinscheduler-service and dolphinscheduler-server
2 participants
@EricGao888 @kezhenxu94