[test] fix flaky test in CI #12017
Merged
[test] fix flaky test in CI #12017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhongjiajie
changed the title
Codecov Report
@@ Coverage Diff @@
## dev #12017 +/- ##
============================================
- Coverage 38.68% 38.66% -0.02%
+ Complexity 4050 4009 -41
============================================
Files 999 1002 +3
Lines 36728 37213 +485
Branches 4276 4247 -29
============================================
+ Hits 14208 14390 +182
- Misses 20896 21190 +294
- Partials 1624 1633 +9
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
zhongjiajie
force-pushed
the
f-flaky-tests
branch
from
5bba15a
to
0dd4d23
Compare
zhongjiajie
commented
Sep 27, 2022
| @@ -0,0 +1 @@ | |||
| mock-maker-inline | |||
There was a problem hiding this comment.
Add this to mock finial class, according to https://github.com/mockito/mockito/wiki/What%27s-new-in-Mockito-2#mock-the-unmockable-opt-in-mocking-of-final-classesmethods
| paramsMap.put(HttpAlertConstants.NAME_REQUEST_TYPE, "POST"); | ||
| paramsMap.put(HttpAlertConstants.NAME_HEADER_PARAMS, "{\"Content-Type\":\"application/json\"}"); | ||
| paramsMap.put(HttpAlertConstants.NAME_BODY_PARAMS, "{\"number\":\"13457654323\"}"); |
There was a problem hiding this comment.
remove some sensitive data in UT
zhongjiajie
changed the title
zhongjiajie
requested review from
kezhenxu94 and
caishunfeng
as code owners
kezhenxu94
previously approved these changes
Sep 28, 2022
zhongjiajie
force-pushed
the
f-flaky-tests
branch
from
1dfffcd
to
df71d5b
Compare
|
SonarCloud Quality Gate failed. |
|
thanks all |
3 tasks
xdu-chenrj
pushed a commit
to xdu-chenrj/dolphinscheduler
that referenced
this pull request
Oct 13, 2022
fuchanghai
pushed a commit
to fuchanghai/dolphinscheduler
that referenced
this pull request
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
com.github.dockerjava.api.exception.ConflictException: Status 409: {"message":"Container 1f0ff7959eb4d1a78a7ba51670c71c438c47d8ec666132fceaa75e94cfa2e2ed is not running"}or container can not start)