Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature][task-plugins] aws datasync task plugins #11865

Merged
merged 40 commits into from
Oct 9, 2022

Conversation

Tianqi-Dotes
Copy link
Member

Purpose of the pull request

close #11663

Brief change log

aws datasync task plugins

Verify this pull request

Manually verified the change by testing locally.

@Tianqi-Dotes Tianqi-Dotes self-assigned this Sep 8, 2022
@Tianqi-Dotes Tianqi-Dotes added this to the 3.1.0 milestone Sep 8, 2022
@Tianqi-Dotes Tianqi-Dotes added feature new feature backend miss:docs missing documents in PR labels Sep 8, 2022
@github-actions github-actions bot added the UI ui and front end related label Sep 8, 2022
@caishunfeng caishunfeng modified the milestones: 3.1.0, 3.2.0 Sep 19, 2022
… feature/aws

� Conflicts:
�	docs/configs/docsdev.js
�	dolphinscheduler-dist/release-docs/LICENSE
�	dolphinscheduler-task-plugin/dolphinscheduler-task-all/pom.xml
�	dolphinscheduler-task-plugin/pom.xml
�	dolphinscheduler-ui/src/store/project/task-type.ts
�	dolphinscheduler-ui/src/store/project/types.ts
�	dolphinscheduler-ui/src/views/projects/task/components/node/fields/index.ts
�	dolphinscheduler-ui/src/views/projects/task/components/node/tasks/index.ts
�	dolphinscheduler-ui/src/views/projects/task/components/node/types.ts
�	dolphinscheduler-ui/src/views/projects/task/constants/task-type.ts
�	dolphinscheduler-ui/src/views/projects/workflow/components/dag/dag.module.scss
@codecov-commenter
Copy link

Codecov Report

Merging #11865 (80da155) into dev (64a23cd) will decrease coverage by 0.02%.
The diff coverage is 34.71%.

@@             Coverage Diff              @@
##                dev   #11865      +/-   ##
============================================
- Coverage     39.65%   39.62%   -0.03%     
- Complexity     4173     4190      +17     
============================================
  Files          1016     1021       +5     
  Lines         38009    38202     +193     
  Branches       4363     4392      +29     
============================================
+ Hits          15072    15139      +67     
- Misses        21197    21316     +119     
- Partials       1740     1747       +7     
Impacted Files Coverage Δ
...duler/plugin/task/datasync/DatasyncParameters.java 0.00% <0.00%> (ø)
...uler/plugin/task/datasync/DatasyncTaskChannel.java 0.00% <0.00%> (ø)
...ugin/task/datasync/DatasyncTaskChannelFactory.java 0.00% <0.00%> (ø)
...inscheduler/plugin/task/datasync/DatasyncTask.java 32.75% <32.75%> (ø)
...inscheduler/plugin/task/datasync/DatasyncHook.java 39.02% <39.02%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Oct 8, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 28 Code Smells

34.1% 34.1% Coverage
2.3% 2.3% Duplication

Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM of the backend.

@Tianqi-Dotes Tianqi-Dotes merged commit c7435a5 into apache:dev Oct 9, 2022
Copy link
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments are not addressed, UI part is not reviewed.

dolphinscheduler-bom/pom.xml Show resolved Hide resolved
Copy link
Member

@Amy0104 Amy0104 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the front end part.

xdu-chenrj pushed a commit to xdu-chenrj/dolphinscheduler that referenced this pull request Oct 13, 2022
* submit datasync task

* add aws software package license
fuchanghai pushed a commit to fuchanghai/dolphinscheduler that referenced this pull request Nov 16, 2022
* submit datasync task

* add aws software package license
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend document feature new feature miss:docs missing documents in PR UI ui and front end related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][TASK-PLUGIN] AWS DataSync Operator
5 participants