[Feature-6586][Server]add some ds process definition demo when init #11759

amaoisnb · 2022-09-02T12:56:06Z

[Feature-6586][Server]add some ds process definition demo when init
1.add some ds process definition demo when init, to display what task type can run and make user easy to
use ds.
2.need configure the JVM parameters (-Ddemo=true) to turn on the StandaloneServer service
3.need modify the tenant information in it

1.add some ds process definition demo when init, to display what task type can run and make user easy to use ds. 2.need configure the JVM parameters (-Ddemo=true) to turn on the StandaloneServer service 3.need modify the tenant information in it

EricGao888 · 2022-09-03T10:24:18Z

Hi @amaoisnb , you could add closes: #6586 in you PR description to automatically link this PR to the issue it solves.

EricGao888 · 2022-09-03T10:24:32Z

related: #6586

dolphinscheduler-standalone-server/src/main/bin/start.sh

closes: apache#6586

SbloodyS

Please resolve conflicts.

BTW. It's better to use english in the commit message.

resolve the conflict

# Conflicts: # dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/ProcessDefinitionControllerTest.java

dolphinscheduler-server/pom.xml

...rc/test/java/org/apache/dolphinscheduler/api/controller/ProcessDefinitionControllerTest.java

dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/demo/DemoContants.java

kezhenxu94 · 2022-09-06T04:00:21Z

I don’t think this is a good idea to couple the demo codes with the production code. At least, you should move the demo codes to the module dolphinscheduler-tools, and execute that tool after starting DS server. Mixing the demo codes and production code increases maintainability complexity

SbloodyS · 2022-09-06T04:01:24Z

I don’t think this is a good idea to couple the demo codes with the production code. At least, you should move the demo codes to the module dolphinscheduler-tools, and execute that tool after starting DS server. Mixing the demo codes and production code increases maintainability complexity

+1

EricGao888 · 2022-09-06T04:01:49Z

I don’t think this is a good idea to couple the demo codes with the production code. At least, you should move the demo codes to the module dolphinscheduler-tools, and execute that tool after starting DS server. Mixing the demo codes and production code increases maintainability complexity

+1

ruanwenjun · 2022-09-07T03:51:15Z

I don’t think this is a good idea to couple the demo codes with the production code. At least, you should move the demo codes to the module dolphinscheduler-tools, and execute that tool after starting DS server. Mixing the demo codes and production code increases maintainability complexity

+1

...uler-tools/src/main/java/org/apache/dolphinscheduler/tools/datasource/CreateProcessDemo.java

create demo-tool

spotless

codecov-commenter · 2022-10-30T13:04:02Z

Codecov Report

Merging #11759 (f8e5db3) into dev (77e29b5) will decrease coverage by 0.56%.
The diff coverage is 26.16%.

❗ Current head f8e5db3 differs from pull request most recent head 1c41397. Consider uploading reports for the commit 1c41397 to get more accurate results

@@             Coverage Diff              @@
##                dev   #11759      +/-   ##
============================================
- Coverage     39.61%   39.04%   -0.57%     
+ Complexity     4192     4183       -9     
============================================
  Files          1038     1043       +5     
  Lines         38843    39506     +663     
  Branches       4447     4544      +97     
============================================
+ Hits          15387    15426      +39     
- Misses        21712    22324     +612     
- Partials       1744     1756      +12

Impacted Files	Coverage Δ
...eduler/plugin/alert/script/ScriptAlertChannel.java	`16.66% <0.00%> (ø)`
...che/dolphinscheduler/alert/AlertSenderService.java	`46.00% <0.00%> (ø)`
...scheduler/api/controller/AlertGroupController.java	`78.57% <ø> (ø)`
...hinscheduler/api/controller/ClusterController.java	`89.47% <ø> (ø)`
...cheduler/api/controller/DataQualityController.java	`64.70% <ø> (ø)`
...cheduler/api/controller/EnvironmentController.java	`90.47% <ø> (ø)`
...inscheduler/api/controller/ExecutorController.java	`19.73% <ø> (ø)`
...hinscheduler/api/controller/FavTaskController.java	`14.28% <0.00%> (ø)`
...hinscheduler/api/controller/ProjectController.java	`50.00% <0.00%> (-18.43%)`	⬇️
...nscheduler/api/controller/TaskGroupController.java	`83.33% <ø> (ø)`
... and 98 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

github-advanced-security

CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

fix bug

docs/docs/en/guide/demo.md

docs/docs/zh/guide/demo.md

...inscheduler-tools/src/main/java/org/apache/dolphinscheduler/tools/demo/CreateDemoTenant.java

...eduler-tools/src/main/java/org/apache/dolphinscheduler/tools/demo/ProcessDefinitionDemo.java

docs/docs/en/guide/demo.md

adjustments

kezhenxu94

Previous comments are addressed, basically LGTM

dolphinscheduler-tools/src/main/java/org/apache/dolphinscheduler/tools/demo/ProxyResult.java

docs/docs/zh/guide/demo.md

dolphinscheduler-tools/src/main/bin/demo-start.sh

...s/src/main/java/org/apache/dolphinscheduler/tools/demo/ProxyProcessDefinitionController.java

kezhenxu94 · 2022-10-31T07:24:22Z

...s/src/main/java/org/apache/dolphinscheduler/tools/demo/ProxyProcessDefinitionController.java

+        requestBodyMap.put("executionType", executionType);
+
+        try {
+            responseBody = OkHttpUtils.demoPost(url, token, requestBodyMap);


Ideally, I would prefer we should use RestTemplate to perform http requests, but this looks OK to me if you want to refactor later.

Then I'll look at it and try to make adjustments

some adjustments

some doc adjustments

kezhenxu94 · 2022-10-31T11:48:41Z

The comments are not addressed but you click resolve conversation, please fix or reply if you think it's wrong. Don't simply mark it as resolved.

amaoisnb · 2022-10-31T12:16:26Z

The comments are not addressed but you click resolve conversation, please fix or reply if you think it's wrong. Don't simply mark it as resolved.

I'm sorry I didn't reply to this

make some adjustments

dolphinscheduler-tools/src/main/java/org/apache/dolphinscheduler/tools/demo/ProxyResult.java

make some adjustments

sonarcloud · 2022-10-31T14:08:14Z

SonarCloud Quality Gate failed.

1 Bug
0 Vulnerabilities
0 Security Hotspots
98 Code Smells

0.0% Coverage
39.4% Duplication

caishunfeng

LGTM if CI pass

…pache#11759) * [Feature-6586][Server]add some ds process definition demo when init 1.add some ds process definition demo when init, to display what task type can run and make user easy to use ds. 2.need configure the JVM parameters (-Ddemo=true) to turn on the StandaloneServer service 3.need modify the tenant information in it

…n init (apache#11759)" This reverts commit 72c985c.

cqutwangyu · 2024-03-12T06:50:21Z

Is this demo still working?
What are the preconditions?

amaoisnb added 5 commits August 16, 2022 13:07

0816

ff6ace4

0819

aa5cc0c

单机启动完成

b9f7926

0829

00026e6

amaoisnb requested review from kezhenxu94, caishunfeng, SbloodyS, zhongjiajie and EricGao888 as code owners September 2, 2022 12:56

github-actions bot added the backend label Sep 2, 2022

amaoisnb changed the title ~~Feature 6586~~ [Feature-6586][Server]add some ds process definition demo when init Sep 2, 2022

SbloodyS added the first time contributor First-time contributor label Sep 3, 2022

SbloodyS assigned amaoisnb Sep 3, 2022

SbloodyS added the feature new feature label Sep 3, 2022

SbloodyS reviewed Sep 3, 2022

View reviewed changes

dolphinscheduler-standalone-server/src/main/bin/start.sh Outdated Show resolved Hide resolved

[Feature-6586][Server]

61c6810

closes: apache#6586

SbloodyS reviewed Sep 4, 2022

View reviewed changes

amaoisnb and others added 3 commits September 4, 2022 14:02

Delete ProcessDefinitionControllerTest.java

8414079

[Feature-6586][Server]

8af9894

resolve the conflict

Merge remote-tracking branch 'origin/Feature-6586' into Feature-6586

0393d9b

# Conflicts: # dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/ProcessDefinitionControllerTest.java

caishunfeng requested changes Sep 6, 2022

View reviewed changes

ruanwenjun reviewed Sep 7, 2022

View reviewed changes

...uler-tools/src/main/java/org/apache/dolphinscheduler/tools/datasource/CreateProcessDemo.java Outdated Show resolved Hide resolved

[Feature-6586][Server]

7bb211d

create demo-tool

amaoisnb dismissed caishunfeng’s stale review via b0e4bbd October 30, 2022 12:17

[Feature-6586][Server]

a0a1193

spotless

github-advanced-security bot found potential problems Oct 30, 2022

View reviewed changes

[Feature-6586][Server]

31b2581

fix bug

zhongjiajie reviewed Oct 31, 2022

View reviewed changes

[Feature-6586][Server]

b638e0e

adjustments

amaoisnb requested review from zhongjiajie and removed request for Tianqi-Dotes, songjianet, Amy0104, zhuangchong and kezhenxu94 October 31, 2022 02:59

caishunfeng requested a review from kezhenxu94 October 31, 2022 04:18

kezhenxu94 previously approved these changes Oct 31, 2022

View reviewed changes

[Feature-6586][Server]

ef262a3

some adjustments

amaoisnb dismissed kezhenxu94’s stale review via ef262a3 October 31, 2022 07:53

[Feature-6586][Server]

c7bd3b1

some doc adjustments

[Feature-6586][Server]

eb686cf

make some adjustments

caishunfeng reviewed Oct 31, 2022

View reviewed changes

dolphinscheduler-tools/src/main/java/org/apache/dolphinscheduler/tools/demo/ProxyResult.java Outdated Show resolved Hide resolved

amaoisnb added 2 commits October 31, 2022 20:41

[Feature-6586][Server]

7f4de20

make some adjustments

[Feature-6586][Server]

1c41397

make some adjustments

caishunfeng approved these changes Oct 31, 2022

View reviewed changes

caishunfeng merged commit b71d498 into apache:dev Oct 31, 2022

hstdream pushed a commit to hstdream/dolphinscheduler that referenced this pull request Nov 2, 2022

Revert "[Feature-6586][Server]add some ds process definition demo whe…

8b1b5aa

…n init (apache#11759)" This reverts commit 72c985c.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Feature-6586][Server]add some ds process definition demo when init #11759

[Feature-6586][Server]add some ds process definition demo when init #11759

amaoisnb commented Sep 2, 2022

EricGao888 commented Sep 3, 2022

EricGao888 commented Sep 3, 2022

SbloodyS left a comment

kezhenxu94 commented Sep 6, 2022

SbloodyS commented Sep 6, 2022

EricGao888 commented Sep 6, 2022

ruanwenjun commented Sep 7, 2022

codecov-commenter commented Oct 30, 2022 •

edited

Loading

github-advanced-security bot left a comment

kezhenxu94 left a comment

kezhenxu94 Oct 31, 2022

amaoisnb Oct 31, 2022

kezhenxu94 commented Oct 31, 2022

amaoisnb commented Oct 31, 2022

sonarcloud bot commented Oct 31, 2022

caishunfeng left a comment

cqutwangyu commented Mar 12, 2024

[Feature-6586][Server]add some ds process definition demo when init #11759

[Feature-6586][Server]add some ds process definition demo when init #11759

Conversation

amaoisnb commented Sep 2, 2022

EricGao888 commented Sep 3, 2022

EricGao888 commented Sep 3, 2022

SbloodyS left a comment

Choose a reason for hiding this comment

kezhenxu94 commented Sep 6, 2022

SbloodyS commented Sep 6, 2022

EricGao888 commented Sep 6, 2022

ruanwenjun commented Sep 7, 2022

codecov-commenter commented Oct 30, 2022 • edited Loading

Codecov Report

github-advanced-security bot left a comment

Choose a reason for hiding this comment

kezhenxu94 left a comment

Choose a reason for hiding this comment

kezhenxu94 Oct 31, 2022

Choose a reason for hiding this comment

amaoisnb Oct 31, 2022

Choose a reason for hiding this comment

kezhenxu94 commented Oct 31, 2022

amaoisnb commented Oct 31, 2022

sonarcloud bot commented Oct 31, 2022

caishunfeng left a comment

Choose a reason for hiding this comment

cqutwangyu commented Mar 12, 2024

codecov-commenter commented Oct 30, 2022 •

edited

Loading