[DSIP-13][python] New mechanism file plugins to Python API #11360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xdu-chenrj
requested review from
zhongjiajie,
caishunfeng,
SbloodyS,
ruanwenjun and
kezhenxu94
as code owners
|
@xdu-chenrj Please associate the issue. |
zhongjiajie
reviewed
Aug 9, 2022
There was a problem hiding this comment.
There are a few things you need to task case:
- do not change some thing unrelated to PR
- we have it own code style formatted by
balck, you can runtox -e local-cito check it locally, see more detail in https://github.com/apache/dolphinscheduler/blob/dev/dolphinscheduler-python/pydolphinscheduler/DEVELOP.md#test-your-code - You should directly tell the user how to do instead of what should not do first
dolphinscheduler-python/pydolphinscheduler/src/pydolphinscheduler/core/process_definition.py
Outdated
Show resolved
Hide resolved
dolphinscheduler-python/pydolphinscheduler/src/pydolphinscheduler/core/process_definition.py
Outdated
Show resolved
Hide resolved
dolphinscheduler-python/pydolphinscheduler/docs/source/resources_plugin/how-to-develop.rst
Outdated
Show resolved
Hide resolved
dolphinscheduler-python/pydolphinscheduler/docs/source/resources_plugin/how-to-develop.rst
Outdated
Show resolved
Hide resolved
dolphinscheduler-python/pydolphinscheduler/docs/source/resources_plugin/how-to-use.rst
Outdated
Show resolved
Hide resolved
dolphinscheduler-python/pydolphinscheduler/docs/source/resources_plugin/local.rst
Outdated
Show resolved
Hide resolved
dolphinscheduler-python/pydolphinscheduler/docs/source/resources_plugin/local.rst
Outdated
Show resolved
Hide resolved
…ler/constants.py Only local is reserved Co-authored-by: Jiajie Zhong <[email protected]>
xdu-chenrj
requested review from
zhongjiajie,
SbloodyS and
ruanwenjun
and removed request for
caishunfeng,
kezhenxu94,
SbloodyS,
ruanwenjun and
zhongjiajie
|
Kudos, SonarCloud Quality Gate passed!
|
zhongjiajie
dismissed stale reviews from SbloodyS and ruanwenjun
already remove the unnecessary code
zhongjiajie
changed the title
fengjian1129
pushed a commit
to fengjian1129/dolphinscheduler
that referenced
this pull request
Sep 13, 2022
xdu-chenrj
added a commit
to xdu-chenrj/dolphinscheduler
that referenced
this pull request
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
This pull request adds a local resource plug-in feature #10911
Brief change log
Verify this pull request
This change added tests and can be verified as follows: