Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement][K8S TASK] get namespace's information until execute #14995

Closed
3 tasks done
fuchanghai opened this issue Oct 9, 2023 · 8 comments
Closed
3 tasks done

[Improvement][K8S TASK] get namespace's information until execute #14995

fuchanghai opened this issue Oct 9, 2023 · 8 comments
Assignees
Labels
improvement make more easy to user or prompt friendly Stale

Comments

@fuchanghai
Copy link
Member

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

  • store namespaceId when save process definition
  • before run process instance ,according namespaceId get namespace name and other information

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@fuchanghai fuchanghai added improvement make more easy to user or prompt friendly Waiting for reply Waiting for reply labels Oct 9, 2023
@fuchanghai fuchanghai changed the title [Improvement][K8S TASK] get namespace until execute [Improvement][K8S TASK] get namespace's information until execute Oct 9, 2023
@Radeity
Copy link
Member

Radeity commented Oct 10, 2023

Hi @fuchanghai , I don't get your point, would you like to give some further explanation of this issue?

@rickchengx rickchengx removed the Waiting for reply Waiting for reply label Oct 11, 2023
@fuchanghai
Copy link
Member Author

Hi @fuchanghai , I don't get your point, would you like to give some further explanation of this issue?

hi @Radeity

Currently, the k8s node stores the namespace name. If you want to modify the name, the process definition associated with the namespace needs to be modified

@Radeity
Copy link
Member

Radeity commented Oct 11, 2023

Hi @fuchanghai , I don't get your point, would you like to give some further explanation of this issue?

hi @Radeity

Currently, the k8s node stores the namespace name. If you want to modify the name, the process definition associated with the namespace needs to be modified

Oh, you mean namespace in k8s task's parameter. How about directly remove t_ds_k8s_namespace? cc @Gallardot

@Gallardot
Copy link
Member

Oh, you mean namespace in k8s task's parameter. How about directly remove t_ds_k8s_namespace? cc @Gallardot

I think the solution described by @fuchanghai would be helpful in resolving this issue.

What does directly remove t_ds_k8s_namespace means ? @Radeity

@Radeity
Copy link
Member

Radeity commented Oct 11, 2023

Oh, you mean namespace in k8s task's parameter. How about directly remove t_ds_k8s_namespace? cc @Gallardot

I think the solution described by @fuchanghai would be helpful in resolving this issue.

What does directly remove t_ds_k8s_namespace means ? @Radeity

I think we don't have to maintain this table and we can remove namespace management, since now we don't have the ability to manage namespace in k8s cluster. Thus, namespace is same with image in k8s task's parameters. Considering user-friendliness, maybe we can use project-level parameter to define these task parameter.

@Gallardot
Copy link
Member

I think we don't have to maintain this table and we can remove namespace management, since now we don't have the ability to manage namespace in k8s cluster. Thus, namespace is same with image in k8s task's parameters. Considering user-friendliness, maybe we can use project-level parameter to define these task parameter.

But currently, the dolphinscheduler has the authority to manage namespaces, and specific dolphinscheduler users can use the namespace permissions of specific clusters, which is beneficial for both permission management and ease of use.

Copy link

This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.

@github-actions github-actions bot added the Stale label Nov 17, 2023
Copy link

This issue has been closed because it has not received response for too long time. You could reopen it if you encountered similar problems in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement make more easy to user or prompt friendly Stale
Projects
None yet
Development

No branches or pull requests

4 participants