Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement][Metrics] Apply micrometer naming convention to metrics #10432

Closed
3 tasks done
EricGao888 opened this issue Jun 13, 2022 · 1 comment · Fixed by #10477
Closed
3 tasks done

[Improvement][Metrics] Apply micrometer naming convention to metrics #10432

EricGao888 opened this issue Jun 13, 2022 · 1 comment · Fixed by #10477
Assignees
Labels

Comments

@EricGao888
Copy link
Member

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

Inconsistent naming will cause portability and compatibility issues, as well as, make users confused when the number of metrics gets large. Therefore, we need to:

  • Establish the naming convention for DS metrics.
  • Change the current metrics names following the convention.

We could refer to official docs micrometers metrics naming convention for details.

  • One possible approach and example could be found here in naming convention section.

Use case

No response

Related issues

releated: #9324

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@EricGao888 EricGao888 added feature new feature Waiting for reply Waiting for reply labels Jun 13, 2022
@github-actions
Copy link

Thank you for your feedback, we have received your issue, Please wait patiently for a reply.

  • In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
  • If you haven't received a reply for a long time, you can join our slack and send your question to channel #troubleshooting

@SbloodyS SbloodyS added backend and removed Waiting for reply Waiting for reply labels Jun 14, 2022
@EricGao888 EricGao888 changed the title [Improvement][Metrics] Change metrics name following naming convention [Improvement][Metrics] Apply micrometer naming convention to metrics Jun 16, 2022
EricGao888 added a commit to EricGao888/dolphinscheduler that referenced this issue Jun 16, 2022
EricGao888 added a commit to EricGao888/dolphinscheduler that referenced this issue Jun 16, 2022
EricGao888 added a commit to EricGao888/dolphinscheduler that referenced this issue Jun 19, 2022
EricGao888 added a commit to EricGao888/dolphinscheduler that referenced this issue Jun 19, 2022
EricGao888 added a commit to EricGao888/dolphinscheduler that referenced this issue Jun 20, 2022
EricGao888 added a commit to EricGao888/dolphinscheduler that referenced this issue Jun 20, 2022
EricGao888 added a commit to EricGao888/dolphinscheduler that referenced this issue Jun 22, 2022
hstdream pushed a commit to hstdream/dolphinscheduler that referenced this issue Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants