Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Minimum Supported Rust Version policy to docs #9681

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Mar 18, 2024

Which issue does this PR close?

Closes #9082

Rationale for this change

We discussed the policy and seemed to have reasonable consensus on 6 months as part of #9082.

However, we never documented it and so we got at least one PR that proposed to break the MSRV: #9659

What changes are included in this PR?

  1. Document the "6 months MSRV policy"

Are these changes tested?

CI

Are there any user-facing changes?

@alamb alamb marked this pull request as ready for review March 18, 2024 18:48
@alamb alamb marked this pull request as draft March 18, 2024 18:48
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Mar 18, 2024
Copy link
Contributor Author

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically speaking I think we can increase this version 1.73 tomorrow given 1.72.1 was released in september

https://github.com/rust-lang/rust/blob/master/RELEASES.md#version-1721-2023-09-19

Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks @alamb for documenting it

Copy link
Member

@Ted-Jiang Ted-Jiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@alamb alamb merged commit 55aacf6 into apache:main Mar 20, 2024
3 checks passed
@alamb
Copy link
Contributor Author

alamb commented Mar 20, 2024

Thanks @comphead and @Ted-Jiang

@alamb alamb deleted the alamb/msrv_docs branch March 20, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DISCUSSION] Define a MSRV (Minimum Supported Rust Version) policy
3 participants