Minor: Remove redundant dependencies from datafusion-functions/Cargo.toml
#9622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Mar 15, 2024
| @@ -57,8 +57,6 @@ path = "src/lib.rs" | |||
|
|
|||
| [dependencies] | |||
| arrow = { workspace = true } | |||
| arrow-array = { workspace = true } | |||
There was a problem hiding this comment.
The point of the PR is to remove these two lines. The rest of the changes were driven by the compiler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #9285
Rationale for this change
datafusion-functionsalready depends on arrow, so bringing dependencies on the arrow subcrates simply makes the use's less clear and consistent (and requires patching multiple crates if you want to patch out arrow)What changes are included in this PR?
arrow-schemaandarrow-arrayfromdatafusion-functions/Cargo.tomlusestatementsAre these changes tested?
By existing CI
Are there any user-facing changes?