Port ArrayResize to functions-array subcrate
#9570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
logical-expr
erenavsarogullari
changed the title
ArrayResize to function-arrays subcrateArrayResize to functions-arrays subcrate
erenavsarogullari
changed the title
ArrayResize to functions-arrays subcrateArrayResize to functions-array subcrate
Weijun-H
reviewed
Mar 12, 2024
| @@ -238,7 +238,7 @@ select log(-1), log(0), sqrt(-1); | |||
| | array_intersect(array1, array2) | Returns an array of the elements in the intersection of array1 and array2. `array_intersect([1, 2, 3, 4], [5, 6, 3, 4]) -> [3, 4]` | | |||
| | array_union(array1, array2) | Returns an array of the elements in the union of array1 and array2 without duplicates. `array_union([1, 2, 3, 4], [5, 6, 3, 4]) -> [1, 2, 3, 4, 5, 6]` | | |||
| | array_except(array1, array2) | Returns an array of the elements that appear in the first array but not in the second. `array_except([1, 2, 3, 4], [5, 6, 3, 4]) -> [3, 4]` | | |||
| | array_resize(array, size, value) | Resizes the list to contain size elements. Initializes new elements with value or empty if value is not set. `array_resize([1, 2, 3], 5, 0) -> [1, 2, 3, 4, 5, 6]` | | |||
| | array_resize(array, size, value) | Resizes the list to contain size elements. Initializes new elements with value or empty if value is not set. `array_resize([1, 2, 3], 5, 0) -> [1, 2, 3, 0, 0]` | | |||
| field.data_type().clone(), | ||
| true, | ||
| )))), | ||
| _ => exec_err!( |
There was a problem hiding this comment.
nit
Suggested change
| _ => exec_err!( | |
| List(field) | FixedSizeList(field, _) => Ok(List(field.clone())), | |
| LargeList(field) => Ok(LargeList(field.clone())), |
Weijun-H
approved these changes
Mar 13, 2024
alamb
approved these changes
Mar 13, 2024
There was a problem hiding this comment.
Thank you very much @erenavsarogullari and @Weijun-H for the review
| @@ -893,6 +895,100 @@ pub fn array_length(args: &[ArrayRef]) -> Result<ArrayRef> { | |||
| } | |||
| } | |||
|
|
|||
| /// array_resize SQL function | |||
There was a problem hiding this comment.
I think @jayzhan211 may have a plan to split these functions up into different modules (e.g. not one giant kernels.rs file). No changes needed for this PR, just FYI
There was a problem hiding this comment.
Thanks @alamb. Yes, our direction will be like that with the next PR.
alamb
reviewed
Mar 13, 2024
| @@ -2082,6 +2084,36 @@ array_sort(array, desc, nulls_first) | |||
|
|
|||
| - list_sort | |||
|
|
|||
| ### `array_resize` | |||
There was a problem hiding this comment.
Its cool to see improvements to the documentation as part of the porting over 👍
43 tasks
|
Since I was taking a pass through anyways, I merged this PR up to main and fixed a compilation error. |
|
Thanks again @erenavsarogullari and @jayzhan211 |
|
Thanks @alamb for follow-up and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #9569.
What changes are included in this PR?
This PR aims to do following changes in terms of Epic #9285:
1-
ArrayResizeis ported tofunctions-arraysubcrate,2-
array_resizefunction documentation is added.Are these changes tested?
Yes, all
array.sltbasedarray_resizetests are passed.Are there any user-facing changes?
No