Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port ArrayRepeat to functions-array subcrate #9568

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Port ArrayRepeat to functions-array subcrate #9568

merged 1 commit into from
Mar 13, 2024

Conversation

erenavsarogullari
Copy link
Member

@erenavsarogullari erenavsarogullari commented Mar 12, 2024 •
edited
Loading

Which issue does this PR close?

Closes #9565.

What changes are included in this PR?

This PR aims to do following changes in terms of Epic #9285:
1- ArrayRepeat is ported to functions-array subcrate,
2- Minor cleanup by removing redundant package definitions.

Are these changes tested?

Yes, all array.slt based array_repeat tests are passed.

Are there any user-facing changes?

No

@github-actions github-actions bot added logical-expr Logical plan and expressions physical-expr Physical Expressions labels Mar 12, 2024
@erenavsarogullari erenavsarogullari changed the title Port ArrayRepeat to function-arrays subcrate Port ArrayRepeat to functions-array subcrate Mar 12, 2024
jayzhan211
jayzhan211 approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@jayzhan211 jayzhan211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

comphead
comphead approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks @erenavsarogullari please check the conflicting files

@erenavsarogullari
Copy link
Member Author

erenavsarogullari commented Mar 13, 2024 •
edited
Loading

Thanks @jayzhan211 and @comphead for the review. Merge conflicts have just been addressed.

@erenavsarogullari
Copy link
Member Author

cargo test (win64) build stage is failed due to:

error: could not remove 'setup' file: 'C:\Users\runneradmin\.cargo\bin/rustup-init.exe': Access is denied. (os error 5)

Is it possible to re-trigger the build?

@jayzhan211
Copy link
Contributor

cargo test (win64) build stage is failed due to:

error: could not remove 'setup' file: 'C:\Users\runneradmin\.cargo\bin/rustup-init.exe': Access is denied. (os error 5)

Is it possible to re-trigger the build?

I had re-run it once, but the same error is occured.

@jayzhan211 jayzhan211 merged commit 78bb64e into apache:main Mar 13, 2024
23 checks passed
@erenavsarogullari
Copy link
Member Author

@jayzhan211 Thanks for triggering the build and merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayzhan211 jayzhan211 jayzhan211 approved these changes

@comphead comphead comphead approved these changes

Assignees
No one assigned
Labels
logical-expr Logical plan and expressions physical-expr Physical Expressions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Port ArrayRepeat to functions-array subcrate
3 participants
@erenavsarogullari @jayzhan211 @comphead