Add example for ScalarStructBuilder::new_null, fix display for null ScalarValue::Struct
#9238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
changed the title
ScalarStructBuilder::new_nullScalarStructBuilder::new_null, fix display for null ScalarValue::Struct
alamb
changed the title
ScalarStructBuilder::new_null, fix display for null ScalarValue::StructScalarStructBuilder::new_null, fix display for null ScalarValue::Struct
viirya
reviewed
Feb 15, 2024
Comment on lines
+44
to
+46
| /// Note this is different from a struct where each of the specified fields | ||
| /// are null (e.g. `{a: NULL}`) | ||
| /// |
appletreeisyellow
approved these changes
Feb 15, 2024
alamb
commented
Feb 16, 2024
| @@ -3103,6 +3103,11 @@ impl fmt::Display for ScalarValue { | |||
| // ScalarValue Struct should always have a single element | |||
| assert_eq!(struct_arr.len(), 1); | |||
|
|
|||
| if struct_arr.null_count() == struct_arr.len() { | |||
| let batch = RecordBatch::try_from_iter(vec![("s", arr as _)]).unwrap(); | ||
|
|
||
| #[rustfmt::skip] | ||
| let expected = [ |
There was a problem hiding this comment.
This shows that new_null really does create a null value (and thus the change to impl Display is correct)
|
FYI @jayzhan211 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follow on to #9229
related to #9227
Rationale for this change
@NGA-TRAN asked internally about exactly what
ScalarStructBuilder::new_nullinternally so I wanted to document it in an example here.When I did the PR the display didn't match what I thought
new_nulldid, so I fixed a bug in null display as wellWhat changes are included in this PR?
ScalarStructBuilder::new_nullScalarValue::Structnull displayAre these changes tested?
Yes, new test and by CI
Are there any user-facing changes?