-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add github action to self-assign the issue #9132
Conversation
Signed-off-by: Nikolay Ulmasov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will save me a bunch of github alerts. Love it. Thanks again @r3stl355 |
Signed-off-by: Nikolay Ulmasov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
jobs: | ||
issue_assign: | ||
runs-on: ubuntu-latest | ||
if: (!github.event.issue.pull_request) && github.event.comment.body == 'take' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious, is this case-insensitive? Though not sure what preference is (since take
might seem a more obvious command than Take
🤷)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably case sensitive. There are few ways to make it more robust - remove spaces, make lowercase, etc but I just wanted to start with something
Let's merge this one in and we can improve the workflow (e.g. with case insensitivity) as we get experience with it Thanks again @r3stl355 |
Which issue does this PR close?
Closes #9124
Rationale for this change
Simplify the process of assigning the issue to the contributor
What changes are included in this PR?
An additional GitHub workflow that would run in response to work
take
submitted as a commentAre these changes tested?
Not tested in this repo but I have implemented the same in couple of other repos and they work fine
Are there any user-facing changes?
Yes. User's can self-assign the issues. Also added a new paragraph to the
docs/source/contributing-guide/index.md
using my own wording, happy to make any changes there if needed.