Add ColumnarValue::values_to_arrays, deprecate columnar_values_to_array
#9114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
logical-expr
alamb
commented
Feb 2, 2024
| let args = columnar_values_to_array(args)?; | ||
| // Expand the arguments to arrays (this is simple, but inefficient for | ||
| // single constant values). | ||
| let args = ColumnarValue::values_to_arrays(args)?; |
There was a problem hiding this comment.
This is the basic change -- make the logic a function of ColumnarValue
| /// # Errors | ||
| /// | ||
| /// If there are multiple array arguments that have different lengths | ||
| pub fn values_to_arrays(args: &[ColumnarValue]) -> Result<Vec<ArrayRef>> { |
There was a problem hiding this comment.
This is a different algorithm than columnar_values_to_array as it also handles mixed ScalarValue and ArrayRefs
| use super::*; | ||
|
|
||
| #[test] | ||
| fn values_to_arrays() { |
|
In the make_date code I was attempting to not actually expand the scalar into a full array but rather use in place. It was one of the reasons why I was asking about a SingleValueArray as with something like that we could have the best of both - easy processing and no data duplication. I feel though that would likely be a lot more work than it seems it would be otherwise |
viirya
reviewed
Feb 2, 2024
viirya
reviewed
Feb 2, 2024
Co-authored-by: Liang-Chi Hsieh <[email protected]>
|
Thanks again for the review @viirya |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #8045
Rationale for this change
While working on implementing
ArrayToStringin #9113 I found that many of the array functions support arbitrary combinations of arguments that areColumnarValuetoArrayby converting all the arguments to arrays and then calling a function that works on arrays.I think this is a common desire when implementing functions, but it is not always clear how to do this.
For example I think @Omega359 had to implement something similar in
to_datein #9040@viirya added a helper in #8962 which improves the situation, but I think this function may be hard to find (it is in
datafusion_physical_expr) and it doesn't handle the case where the arguments are a mix ofColumnarValue::ScalarandColumnarValue::ArrayWhat changes are included in this PR?
ColumnarValue::values_to_arrayscolumnar_values_to_arrayAre these changes tested?
Yes, new tests
Are there any user-facing changes?
New function, better docs and tests