test: Port tests in partitioned_csv.rs to sqllogictest
#8919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
simicd
commented
Jan 19, 2024
| @@ -482,7 +482,7 @@ async fn sort_on_window_null_string() -> Result<()> { | |||
| async fn test_prepare_statement() -> Result<()> { | |||
| let tmp_dir = TempDir::new()?; | |||
| let partition_count = 4; | |||
| let ctx = partitioned_csv::create_ctx(&tmp_dir, partition_count).await?; | |||
| let ctx = create_ctx_with_partition(&tmp_dir, partition_count).await?; | |||
There was a problem hiding this comment.
The same code existed in partitioned_csv.rs and mod.rs - dropped the former and replaced with function calls to mod.rs
simicd
commented
Jan 19, 2024
| @@ -63,3 +63,76 @@ id6 value"6 | |||
| id7 value"7 | |||
| id8 value"8 | |||
| id9 value"9 | |||
|
|
|||
|
|
|||
| # Read partitioned csv | |||
There was a problem hiding this comment.
partitioned_csv.rs did not have any unit tests so I created a new one to test reading from partitioned csv files.
simicd
commented
Jan 19, 2024
| use tempfile::TempDir; | ||
|
|
||
| /// Generate CSV partitions within the supplied directory | ||
| fn populate_csv_partitions( |
There was a problem hiding this comment.
The exact same setup code exists in mod.rs so deleted this one here.
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #8208
Rationale for this change
Migrate tests from Rust to sqllogictest
What changes are included in this PR?
partitioned_csv.rscsv_files.sltAre these changes tested?
Yes
Are there any user-facing changes?
No