Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add http(s) support to the command line #8753

Merged
merged 7 commits into from
Feb 4, 2024
Merged

Add http(s) support to the command line #8753

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b26dfce
Add http(s) support to the command line
kcolford Jan 4, 2024
ff083c0
Merge remote-tracking branch 'apache/main' into add-http-scheme
alamb Jan 10, 2024
56a3cc1
fmt
alamb Jan 10, 2024
9219b20
Merge remote-tracking branch 'apache/main' into add-http-scheme
alamb Feb 4, 2024
05c697e
Add documentation
alamb Feb 4, 2024
1759457
Add a test
alamb Feb 4, 2024
9b69852
fmt
alamb Feb 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion datafusion-cli/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ dirs = "4.0.0"
env_logger = "0.9"
futures = "0.3"
mimalloc = { version = "0.1", default-features = false }
object_store = { version = "0.8.0", features = ["aws", "gcp"] }
object_store = { version = "0.8.0", features = ["aws", "gcp", "http"] }
parking_lot = { version = "0.12" }
parquet = { version = "49.0.0", default-features = false }
regex = "1.8"
Expand Down
4 changes: 4 additions & 0 deletions datafusion-cli/src/exec.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ use datafusion::prelude::SessionContext;
use datafusion::sql::{parser::DFParser, sqlparser::dialect::dialect_from_str};

use object_store::ObjectStore;
use object_store::http::HttpBuilder;
use rustyline::error::ReadlineError;
use rustyline::Editor;
use tokio::signal;
Expand Down Expand Up @@ -278,6 +279,9 @@ async fn create_external_table(
let builder = get_gcs_object_store_builder(url, cmd)?;
Arc::new(builder.build()?) as Arc<dyn ObjectStore>
}
"http" | "https" => {
Arc::new(HttpBuilder::new().with_url(url.origin().ascii_serialization()).build()?) as Arc<dyn ObjectStore>
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"http" | "https" => {
Arc::new(HttpBuilder::new().with_url(url.origin().ascii_serialization()).build()?) as Arc<dyn ObjectStore>
}
"http" | "https" => {
let builder = HttpBuilder::new().with_url(url.origin().ascii_serialization());
Arc::new(builder.build()?) as Arc<dyn ObjectStore>
}

small nit, just to make it easier on the eyes

_ => {
// for other types, try to get from the object_store_registry
ctx.runtime_env()
Expand Down
Loading