Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sqlparser requirement from 0.40.0 to 0.41.0 #8647

Merged
merged 6 commits into from
Jan 1, 2024
Merged

Update sqlparser requirement from 0.40.0 to 0.41.0 #8647

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
27b2256
Update sqlparser requirement from 0.40.0 to 0.41.0
dependabot[bot] Dec 25, 2023
274eed7
Merge remote-tracking branch 'apache/main' into dependabot/cargo/main…
alamb Dec 26, 2023
1583314
error on unsupported syntax
alamb Dec 26, 2023
4d6bcc2
Update datafusion-cli dependencies
alamb Dec 26, 2023
016cbb8
Merge remote-tracking branch 'apache/main' into dependabot/cargo/main…
alamb Dec 31, 2023
da9eed3
fix test
alamb Dec 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ parquet = { version = "49.0.0", default-features = false, features = ["arrow", "
rand = "0.8"
rstest = "0.18.0"
serde_json = "1"
sqlparser = { version = "0.40.0", features = ["visitor"] }
sqlparser = { version = "0.41.0", features = ["visitor"] }
tempfile = "3"
thiserror = "1.0.44"
url = "2.2"
Expand Down
82 changes: 41 additions & 41 deletions datafusion-cli/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions datafusion/sql/src/statement.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,7 +513,13 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
Statement::StartTransaction {
modes,
begin: false,
modifier,
} => {
if let Some(modifier) = modifier {
return not_impl_err!(
"Transaction modifier not supported: {modifier}"
);
}
let isolation_level: ast::TransactionIsolationLevel = modes
.iter()
.filter_map(|m: &ast::TransactionMode| match m {
Expand Down
6 changes: 3 additions & 3 deletions datafusion/sqllogictest/test_files/repartition_scan.slt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,12 +185,12 @@ COPY (VALUES (1), (2), (3), (4), (5)) TO 'test_files/scratch/repartition_scan/j
(FORMAT json, SINGLE_FILE_OUTPUT true);

statement ok
CREATE EXTERNAL TABLE json_table(column1 int)
CREATE EXTERNAL TABLE json_table (column1 int)
STORED AS json
LOCATION 'test_files/scratch/repartition_scan/json_table/';

query I
select * from json_table;
select * from "json_table";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is needed because JSON_TABLE is now parsed specially in SQLParser: apache/datafusion-sqlparser-rs#1062

----
1
2
Expand All @@ -200,7 +200,7 @@ select * from json_table;

## Expect to see the scan read the file as "4" groups with even sizes (offsets)
query TT
EXPLAIN SELECT column1 FROM json_table WHERE column1 <> 42;
EXPLAIN SELECT column1 FROM "json_table" WHERE column1 <> 42;
----
logical_plan
Filter: json_table.column1 != Int32(42)
Expand Down