Improve array_prepend signature for null and empty array
#8625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jayzhan211 <[email protected]>
github-actions
bot
added
logical-expr
jayzhan211
commented
Dec 22, 2023
|
|
||
| # DuckDB: [[]] | ||
| # ClickHouse: [[]] | ||
| # TODO: We may also return [[]] |
There was a problem hiding this comment.
Unsure should we implement this, return value with larger dimension seems weird to me.
There was a problem hiding this comment.
I agree -- let's not implement this until someone asks for it explicitly
jayzhan211
commented
Dec 22, 2023
|
|
||
| # DuckDB: [null] | ||
| # ClickHouse: [null] | ||
| # TODO: We may also return [null] |
There was a problem hiding this comment.
Same with this one.
There was a problem hiding this comment.
Both cases are not considered in array_append
Weijun-H
approved these changes
Dec 27, 2023
There was a problem hiding this comment.
LGTM! Thanks @jayzhan211 👍
And I could try to test the null for LargeList after #8569 merged.
7 tasks
alamb
approved these changes
Dec 31, 2023
|
|
||
| # DuckDB: [[]] | ||
| # ClickHouse: [[]] | ||
| # TODO: We may also return [[]] |
There was a problem hiding this comment.
I agree -- let's not implement this until someone asks for it explicitly
|
Thank you for the review @Weijun-H |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Part of #7142
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?