Add ForeignKey constraint type #8566
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @simonvandel -- the basic idea looks good to me. It seems we have a few CI failures on this PR |
9 tasks
alamb
reviewed
Jan 5, 2024
There was a problem hiding this comment.
Thank you @simonvandel -- this is looking pretty close. I think there is a bug here, and it would be nice to see some tests that showed that the index lookups are working correctly
This was referenced Jan 8, 2024
gruuya
reviewed
Jan 18, 2024
9 tasks
6 tasks
6 tasks
8 tasks
|
Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days. |
|
Hi @simonvandel. Do you still plan on working on this? |
|
Hi @andygrove If someone else wants the changes, they can use my changes in a new PR. |
|
Thanks @simonvandel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
While toying around with Datafusion, I would like to use foreign key relationship metadata.
What changes are included in this PR?
Extended
ConstraintwithForeignKey.Added conversion from sqslparser's
TableConstraint.Are these changes tested?
Yes, added a test in sql_integration.rs
Are there any user-facing changes?
Yes.
It's now possible to mark columns as foreign keys to other tables.
Adding a new enum variant is a breaking change.