Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: make SubqueryAlias::try_new take Arc<LogicalPlan> #8542

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

sadboy
Copy link
Contributor

@sadboy sadboy commented Dec 14, 2023

Which issue does this PR close?

N/A

Rationale for this change

Currently, all #[non_exhaustive] logical plan structs with a try_new constructor take Arc<LogicalPlan> as parameter, except for SubqueryAlias, which takes a LogicalPlan. This change makes SubqueryAlias::try_new uniform with the other plan type constructors, to improve API ergonomics.

What changes are included in this PR?

  • Change the signature of SubqueryAlias::try_new to take Arc<LogicalPlan> instead of LogicalPlan.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

Currently, all `#[non_exhaustive]` logical plan structs with a `try_new`
constructor take `Arc<LogicalPlan>` as parameter, except for
`SubqueryAlias`, which takes a `LogicalPlan`. This changes
`SubqueryAlias::try_new` to align with the other plan types, to improve API
ergonomics.
@github-actions github-actions bot added the logical-expr Logical plan and expressions label Dec 14, 2023
@Dandandan Dandandan added wontfix api change Changes the API exposed to users of the crate and removed wontfix labels Dec 14, 2023
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @sadboy

@alamb alamb merged commit b457f2b into apache:main Dec 15, 2023
22 checks passed
@sadboy sadboy deleted the bo/subqueryalias_trynew branch December 20, 2023 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api change Changes the API exposed to users of the crate logical-expr Logical plan and expressions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants