Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor/Doc: Clarify DataFrame::write_table Documentation #8519

Merged
merged 2 commits into from
Dec 12, 2023

Conversation

devinjdangelo
Copy link
Contributor

Which issue does this PR close?

Closes #8487

Rationale for this change

Aims to clarify some confusion around DataFrame::write_table and its return type.

What changes are included in this PR?

Updated Doc comment for DataFrame::write_table

Are these changes tested?

na

Are there any user-facing changes?

Updated docs

@github-actions github-actions bot added the core Core DataFusion crate label Dec 12, 2023
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me -- thank you @devinjdangelo

@alamb alamb merged commit 861cc36 into apache:main Dec 12, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataFrame::write_table return type is documented incorrectly
2 participants