Explicitly mark parquet for tests in datafusion-common #8497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alamb, I would appreciate it if you could review this PR to ensure it aligns with our expectations. |
|
Thank you @Dennis40816 -- this looks like a good change and is what I would expect. I have started the CI for this PR |
alamb
approved these changes
Dec 11, 2023
There was a problem hiding this comment.
Thank you @Dennis40816 -- I have just one small request and I think this PR will be good to go
alamb
approved these changes
Dec 12, 2023
|
The CI check seems to be great: https://github.com/apache/arrow-datafusion/actions/runs/7180238066/job/19571832278?pr=8497
|
|
Thanks again @Dennis40816 |
|
Thanks @Dennis40816 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #8250.
Rationale for this change
What changes are included in this PR?
In the tests for
datafusion-common, mark the test programs that require parquet for compilation with#[cfg(feature = "parquet")]. Additionally, in the CI, add a check to verify whetherdatafusion-commoncan compile without any features enabled (bycargo check).Are these changes tested?
Running
cargo test --tests --no-default-features -p datafusion-common.The result is a pass.
Are there any user-facing changes?