fix: incorrect set preserve_partitioning in SortExec #8485
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
related to #8374
Rationale for this change
In #8374, we find
ProjectionPushdown
will incorrectly push projection down and rewrite order by column,before
after
the sort column change from
t1.a, t2.b
tot1.a, t1.b
.However, even if we find the root case, we can still not explain why setting the order by column incorrectly results in an empty output. After doing some tests, I discovered that we did not set the
preserve_partitioning
inSortExec
. As a result,SortExec
only run one partition(instead of all partition), leading to an empty output.What changes are included in this PR?
make
SortExec
'spreserve_patitioning
consistent before and after projection_pushdownAre these changes tested?
yes, add
.slt
testAre there any user-facing changes?