Minor: Remove now dead SUPPORTED_STRUCT_TYPES
#8480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
logical-expr
alamb
force-pushed
the
alamb/delete_unused-code
branch
from
a7b0615
to
676b59e
Compare
|
LGTM in DataFusion context, thank you @alamb Just a question -- it doesn't look like a big deal for this one, but is it fine to remove public constant provided by crate without deprecating it first? |
That is a good question @korowa -- I think it is a judgement call based on if we think removing the In this case I don't think it will have a big impact, though I fully admit I have no data one way or the other |
korowa
approved these changes
Dec 14, 2023
metesynnada
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft until #8463 is mergedWhich issue does this PR close?
Follow on to #8463
Rationale for this change
#8463 removed the last use of
SUPPORTED_STRUCT_TYPESso it is no longer needed in the codeWhat changes are included in this PR?
remove unused code
Are these changes tested?
Covered by existing tests
Are there any user-facing changes?
No