move EmptyExec produce_one_row to be part of MemoryExec #8412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
razeghi71
force-pushed
the
one-row-empty-exec-to-memory-exec
branch
2 times, most recently
from
9e902bf
to
0a8d519
Compare
razeghi71
force-pushed
the
one-row-empty-exec-to-memory-exec
branch
from
0a8d519
to
f5c6cf7
Compare
github-actions
bot
added
optimizer
razeghi71
force-pushed
the
one-row-empty-exec-to-memory-exec
branch
2 times, most recently
from
4d8d85d
to
7dfbd86
Compare
razeghi71
force-pushed
the
one-row-empty-exec-to-memory-exec
branch
from
7dfbd86
to
2312e1f
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #8355.
Rationale for this change
Explained in the issue.
What changes are included in this PR?
In this PR I moved the
produce_one_rowlogic inEmptyExecinto a new constructor inMemoryExec. I haven't found anywhere where the multiple partition case forproduce_one_rowwas used, but I made it so that it also input the number of partitions.What I didn't do in this PR is to change the
LogicalPlan::EmptyRelationto remove theproduct_one_rowlogic there. Probably a good Idea to do this in another PR.Are these changes tested?
Yes, I have brought the tests that we had before in
EmptyExecfor theproduce_one_rowcase over to theMemoryExecand the previous tests are working which I assume contains cases such asSELECT now()orselect 1,2,3(I haven't looked at this honestly, but I can implement this kind of tests also).Are there any user-facing changes?
No.