Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: Refactor function argument handling in ScalarFunctionDefinition #8387

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

Weijun-H
Copy link
Member

@Weijun-H Weijun-H commented Dec 1, 2023

Which issue does this PR close?

Closes #.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

ScalarFunctionDefinition
@github-actions github-actions bot added logical-expr Logical plan and expressions physical-expr Physical Expressions labels Dec 1, 2023
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👨‍🍳 👌 -- very nice @Weijun-H -- thank you for the cleanup

@alamb alamb merged commit a6e6d3f into apache:main Dec 1, 2023
22 checks passed
appletreeisyellow pushed a commit to appletreeisyellow/datafusion that referenced this pull request Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
logical-expr Logical plan and expressions physical-expr Physical Expressions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants