Minor: Move some datafusion-optimizer::utils down to datafusion-expr::utils #8354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
logical-expr
Jesse-Bakker
force-pushed
the
move-utils
branch
from
12b1520
to
de682da
Compare
alamb
approved these changes
Nov 29, 2023
There was a problem hiding this comment.
Thank you @Jesse-Bakker -- this looks great. Leaving deprecation warnings is very good as well
alamb
changed the title
8 tasks
Jesse-Bakker
force-pushed
the
move-utils
branch
from
de682da
to
d9c1878
Compare
These utils manipulate `LogicalPlan`s and `Expr`s and may be useful in projects that only depend on `datafusion-expr`
Jesse-Bakker
force-pushed
the
move-utils
branch
from
d9c1878
to
6ef2039
Compare
|
I always forget about doc-tests 😅 |
|
Thanks again @Jesse-Bakker ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These utils manipulate
LogicalPlans andExprs and may be useful inprojects that only depend on
datafusion-exprWhich issue does this PR close?
Related: #8312 (comment)
Rationale for this change
The moved utils don't depend on anything in
datafusion-optimizerand may bemore broadly useful
What changes are included in this PR?
Move some utils that don't depend on anything optimizer-related from
datafusion-optimizer::utilsto
datafusion-expr::utilsAre there any user-facing changes?
The moved functions are still available under their old names, but will emit
a deprecation warning suggesting to use their new location.