Add quote and escape attributes to create csv external table
#8351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # datafusion/physical-plan/src/joins/hash_join_utils.rs
# Conflicts: # datafusion/physical-plan/src/joins/hash_join_utils.rs
github-actions
bot
added
core
Asura7969
commented
Nov 29, 2023
| WITH HEADER ROW | ||
| DELIMITER ',' | ||
| OPTIONS ('escape' '\"') | ||
| LOCATION '../core/tests/data/escape.csv'; |
There was a problem hiding this comment.
To CREATE EXTERNAL TABLE syntax coverage, I add this file
Asura7969
changed the title
quote & escape for create external table
Asura7969
changed the title
quote & escape for create external tablequote and escape attributes to create csv external table
alamb
reviewed
Nov 29, 2023
alamb
approved these changes
Nov 29, 2023
There was a problem hiding this comment.
Thank you @Asura7969 -- this looks great. I had a suggestion related to settings and it would be nice to add a reference to the comments, but I also think we could merge this PR as is and do them as a follow on.
Let me know what you would like to do.
Thanks again!
8 tasks
I will follow your suggestions |
alamb
approved these changes
Nov 29, 2023
|
Thank you @Asura7969 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #8310.
Rationale for this change
Create csv table in sql mode, support quote & escape
What changes are included in this PR?
Add
quoteandescapeattributes to create csv external tableCREATE EXTERNAL TABLE custom( c1 VARCHAR DEFAULT NULL, c2 VARCHAR DEFAULT NULL ) STORED AS CSV DELIMITER ',' WITH HEADER ROW OPTIONS ('escape' '\', 'quote' '~') LOCATION 'custom.csv';Are these changes tested?
yes,
csv_files.sltAre there any user-facing changes?
Add
quote&escapeattributes to OPTIONS.