Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArraySum #8325

Closed
wants to merge 3 commits into from
Closed

ArraySum #8325

wants to merge 3 commits into from

Conversation

jayzhan211
Copy link
Contributor

@jayzhan211 jayzhan211 commented Nov 27, 2023

Which issue does this PR close?

Ref #7213
Ref #7214
Close #7242

Rationale for this change

Alternative approach to #7242

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Additional Context

@github-actions github-actions bot added sql SQL Planner logical-expr Logical plan and expressions physical-expr Physical Expressions sqllogictest SQL Logic Tests (.slt) labels Nov 27, 2023
Copy link
Member

@Weijun-H Weijun-H left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to see this new feature 👍

array_sum([1, 3, 5]),
array_sum([1.1, 2.2]),
array_sum([1, -1, 0, 22]),
array_sum([1, -1, 0, null, 22]);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
array_sum([1, -1, 0, null, 22]);
array_sum([1, -1, 0, null, 22]),
array_sum([]),
array_sum([null]);

datafusion/sql/src/expr/function.rs Show resolved Hide resolved
Signed-off-by: jayzhan211 <[email protected]>
Signed-off-by: jayzhan211 <[email protected]>
Signed-off-by: jayzhan211 <[email protected]>
@alamb
Copy link
Contributor

alamb commented Feb 2, 2024

I am trying to go through old PRs and make sure we don't lose any -- this one has not had much activity and has accumulated conflicts. Marking as draft so it isn't on the review queue. Please feel free to reopen / mark as ready for review if it is

@alamb alamb marked this pull request as draft February 2, 2024 21:50
Copy link

Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale PR has not had any activity for some time label Apr 21, 2024
@github-actions github-actions bot closed this Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
logical-expr Logical plan and expressions physical-expr Physical Expressions sql SQL Planner sqllogictest SQL Logic Tests (.slt) Stale PR has not had any activity for some time
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement array_aggregate function
3 participants