-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support LargeList
for array_has
, array_has_all
and array_has_any
#8322
Conversation
fcd945f
to
25f87cf
Compare
25f87cf
to
8d6e4b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a really nice PR @Weijun-H -- thank you. I think your refactoring has made the code significantly better. 🦾 🏆
Single, | ||
} | ||
|
||
fn general_array_has_dispatch<O: OffsetSizeTrait>( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
I merged this up from main and will merge once CI passes |
Thanks again @Weijun-H |
…_has_any` (apache#8322) * support LargeList for array_has, array_has_all and array_has_any * simplify the code --------- Co-authored-by: Andrew Lamb <[email protected]>
Which issue does this PR close?
Parts #8185
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?