Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support LargeList for array_has, array_has_all and array_has_any #8322

Merged
merged 3 commits into from
Dec 5, 2023

Conversation

Weijun-H
Copy link
Member

Which issue does this PR close?

Parts #8185

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added physical-expr Physical Expressions sqllogictest SQL Logic Tests (.slt) labels Nov 25, 2023
@Weijun-H Weijun-H marked this pull request as draft November 30, 2023 22:31
@Weijun-H Weijun-H marked this pull request as ready for review December 1, 2023 08:43
@Weijun-H Weijun-H mentioned this pull request Dec 4, 2023
19 tasks
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really nice PR @Weijun-H -- thank you. I think your refactoring has made the code significantly better. 🦾 🏆

Single,
}

fn general_array_has_dispatch<O: OffsetSizeTrait>(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alamb
Copy link
Contributor

alamb commented Dec 5, 2023

I merged this up from main and will merge once CI passes

@alamb alamb merged commit 6dd3c95 into apache:main Dec 5, 2023
22 checks passed
@alamb
Copy link
Contributor

alamb commented Dec 5, 2023

Thanks again @Weijun-H

appletreeisyellow pushed a commit to appletreeisyellow/datafusion that referenced this pull request Dec 15, 2023
…_has_any` (apache#8322)

* support LargeList for array_has, array_has_all and array_has_any

* simplify the code

---------

Co-authored-by: Andrew Lamb <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
physical-expr Physical Expressions sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants