feat: to_array_of_size for ScalarValue::FixedSizeList #8225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is stacked on #8221. The base should automatically change when we merge that one, although I may need to rebase. |
wjones127
force-pushed
the
fsl-scalar-support
branch
from
5e8d784
to
f9159ea
Compare
alamb
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #8220
Rationale for this change
I found this was needed for using literal fixed size lists in DataFusion physical expressions.
What changes are included in this PR?
Implements
eq_arrayandto_array_of_sizeforScalarValue::FixedSizeList.Are these changes tested?
A new unit test is added for each function.
Are there any user-facing changes?
I've updated the documentation to reflect that this is now supported.