fix regression in the use of name in ProjectionPushdown #8219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
optimizer
alamb
force-pushed
the
alamb/fix_column
branch
from
5ee5697
to
8bd70d6
Compare
|
FYI @gruuya |
alamb
commented
Nov 15, 2023
| @@ -228,7 +228,7 @@ impl OptimizerRule for PushDownProjection { | |||
| // Gather all columns needed for expressions in this Aggregate | |||
| let mut new_aggr_expr = vec![]; | |||
| for e in agg.aggr_expr.iter() { | |||
| let column = Column::from(e.display_name()?); | |||
| let column = Column::from_name(e.display_name()?); | |||
There was a problem hiding this comment.
This change was done in #7981 -- it doesn't seem necessary and I think was just a mistake (and did not have adequate test coverage)
There was a problem hiding this comment.
Thanks for resolving this; this was a leftover from my initial attempt to address the qualified alias problem (without altering the Expr::Alias enum) that I forgot to rollback.
There was a problem hiding this comment.
No problem. The real problem is that we had no test coverage for it :(
comphead
approved these changes
Nov 15, 2023
It is very confusing and results in subtle bugs. I'll see if I can find some way to make it better as a follow on PR |
|
Thank you for the quick review @comphead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Resolves #8223
Rationale for this change
We found a bug while upgrading IOx to use the latest datafusion
Some of our queries began failing like this:
The regression was introduced in #7981 and is related to columns with periods in their names
What changes are included in this PR?
DISTINCT ONfrom Postgres #7981Are these changes tested?
yes
Are there any user-facing changes?
bug fix