Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: simplify filter statistics code #8174

Merged
merged 2 commits into from
Nov 15, 2023
Merged

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Nov 14, 2023

Which issue does this PR close?

This is part of #8078

Rationale for this change

I am trying to clean up the existing code's use of Precision so that as we change it (as described on #8078) it will be easier to do so

What changes are included in this PR?

Call into_exact rather than reimplementing the same logic

Are these changes tested?

Covered by existing tests

Are there any user-facing changes?

@github-actions github-actions bot added the core Core DataFusion crate label Nov 14, 2023
Copy link
Contributor

@ozankabak ozankabak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alamb alamb merged commit e1c2f95 into apache:main Nov 15, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants