feat: fill missing values with NULLs while inserting #8146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Nov 13, 2023
There was a problem hiding this comment.
Thank you for the contribution @jonahgao -- it looks really nice to me as always.
| @@ -1098,7 +1103,7 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> { | |||
| .collect::<Vec<_>>(), | |||
| ) | |||
| } else { | |||
| let mut mapping = vec![None; table_schema.fields().len()]; | |||
| let mut value_indices = vec![None; table_schema.fields().len()]; | |||
There was a problem hiding this comment.
I like the new name value_indicies much better
| Values: (Int64(1), Utf8("Alan"), Utf8("Turing")) | ||
| "# | ||
| .trim(); | ||
| let plan = "Dml: op=[Insert Into] table=[person]\ |
|
Thanks @jonahgao |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #8091.
Rationale for this change
If user does not provide a value for certain columns during insertion, NULL will be filled as their default values.
What changes are included in this PR?
Are these changes tested?
Yes
Are there any user-facing changes?
No