-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement range/generate_series func #8140
Conversation
cc @jayzhan211 @alamb this PR is ready for review! : ) |
Thank you for this new function! Looks like these functions are available in DuckDB 👍🏼 https://duckdb.org/docs/sql/functions/nested.html#range-functions Here are some suggestions:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
thanks! I have made it clear in the test and doc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the doc. I think the panic should be addressed. Everything else looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Veeupup -- this looks great. I took the liberty of merging this branch up from main to resolve a conflict.
It would be great if you could add a doc comment explaining the arguments to gen_range
, but I also think we could do that as a follow on PR if necessary.
Thanks again for the recent string of nice PRs 🙏
Signed-off-by: veeupup <[email protected]>
Signed-off-by: veeupup <[email protected]>
Signed-off-by: veeupup <[email protected]>
Thanks again @Veeupup and @jayzhan211 |
Which issue does this PR close?
Closes #8028 .
Rationale for this change
What changes are included in this PR?
Are these changes tested?
test in sqllogictests
Are there any user-facing changes?