Minor: Improve the document format of JoinHashMap #8090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metesynnada
reviewed
Nov 8, 2023
|
I found that the equal_rows macro mentioned in the documentation does not exist and seems to have become equal_rows_arr method @Dandandan |
Yes, could you fix that as well? |
done |
comphead
reviewed
Nov 8, 2023
comphead
reviewed
Nov 8, 2023
alamb
approved these changes
Nov 9, 2023
Thank you for the review @comphead @alamb @Dandandan @metesynnada -- very much appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
Improve the document format of JoinHashMap
What changes are included in this PR?
N/A
Are these changes tested?
doctests
Are there any user-facing changes?
Just Docs