Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: clean useless clone baesd on clippy #7973

Merged
merged 1 commit into from
Oct 29, 2023
Merged

chore: clean useless clone baesd on clippy #7973

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion datafusion/core/src/physical_optimizer/combine_partial_final_agg.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ impl PhysicalOptimizerRule for CombinePartialFinalAggregate {
input_agg_exec.filter_expr().to_vec(),
input_agg_exec.order_by_expr().to_vec(),
input_agg_exec.input().clone(),
input_agg_exec.input_schema().clone(),
input_agg_exec.input_schema(),
)
.ok()
.map(Arc::new)
Expand Down
2 changes: 1 addition & 1 deletion datafusion/core/src/physical_optimizer/enforce_distribution.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -554,7 +554,7 @@ fn reorder_aggregate_keys(
agg_exec.filter_expr().to_vec(),
agg_exec.order_by_expr().to_vec(),
partial_agg,
agg_exec.input_schema().clone(),
agg_exec.input_schema(),
)?);

// Need to create a new projection to change the expr ordering back
Expand Down
2 changes: 1 addition & 1 deletion datafusion/core/src/physical_optimizer/topk_aggregation.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ impl TopKAggregation {
aggr.filter_expr().to_vec(),
aggr.order_by_expr().to_vec(),
aggr.input().clone(),
aggr.input_schema().clone(),
aggr.input_schema(),
)
.expect("Unable to copy Aggregate!")
.with_limit(Some(limit));
Expand Down
2 changes: 1 addition & 1 deletion datafusion/physical-expr/src/array_expressions.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -811,7 +811,7 @@ fn concat_internal(args: &[ArrayRef]) -> Result<ArrayRef> {
}
}
// Assume all arrays have the same data type
let data_type = list_arrays[0].value_type().clone();
let data_type = list_arrays[0].value_type();
let buffer = valid.finish();

let elements = arrays
Expand Down
2 changes: 1 addition & 1 deletion datafusion/substrait/src/logical_plan/producer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,7 @@ pub fn to_substrait_rel(
left: Some(left),
right: Some(right),
r#type: join_type as i32,
expression: join_expr.clone(),
expression: join_expr,
post_join_filter: None,
advanced_extension: None,
}))),
Expand Down