Minor: provide default implementation for ExecutionPlan::statistics #7911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Oct 23, 2023
| @@ -238,10 +238,6 @@ impl ExecutionPlan for UnboundedExec { | |||
| batch: self.batch.clone(), | |||
| })) | |||
| } | |||
|
|
|||
| fn statistics(&self) -> Result<Statistics> { | |||
There was a problem hiding this comment.
The whole point of this PR is to provide this as a default implementation
viirya
approved these changes
Oct 23, 2023
crepererum
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follow on to #7793
Rationale for this change
While integrating #7793 into IOx, I found I had to change many of our
ExecutionPlanimplementations with the boilerplate (but non trivial)ExecutionPlan::statisticsimplementationIn order the ease the upgrade pain for others, we should provide this as a default.
What changes are included in this PR?
ExecutionPlan::statisticsAre these changes tested?
Covered by existing tests
Are there any user-facing changes?
Hopefully a slightly less painful upgrade for #7793