Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support Decimal256 for the abs function #7904

Merged
merged 3 commits into from
Oct 23, 2023
Merged

feat: support Decimal256 for the abs function #7904

merged 3 commits into from
Oct 23, 2023

Conversation

jonahgao
Copy link
Member

@jonahgao jonahgao commented Oct 22, 2023 •
edited by viirya
Loading

Which issue does this PR close?

N/A

Rationale for this change

What changes are included in this PR?

  • Support Decimal256 for the abs function.
  • Minor fixes in the math sql logical test.

Are these changes tested?

Yes

Are there any user-facing changes?

No

@github-actions github-actions bot added physical-expr Physical Expressions sqllogictest SQL Logic Tests (.slt) labels Oct 22, 2023
comphead
comphead reviewed Oct 22, 2023
View reviewed changes
Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps its better to use plan_err or exec_err! instead of ArrowError

@jonahgao
Copy link
Member Author

Perhaps its better to use plan_err or exec_err! instead of ArrowError

Thank you @comphead, but the try_unary requires the returned error type to be ArrowError.

comphead
comphead approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alamb alamb merged commit eee790f into apache:main Oct 23, 2023
23 checks passed
@jonahgao jonahgao deleted the decimal256_abs branch October 24, 2023 02:11
@andygrove andygrove added the enhancement New feature or request label Nov 5, 2023
@matthewgapp matthewgapp mentioned this pull request Jan 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@comphead comphead comphead approved these changes

@viirya viirya viirya approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request physical-expr Physical Expressions sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jonahgao @viirya @comphead @alamb @andygrove