Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix precision loss when coercing date_part utf8 argument #7846

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Fix precision loss when coercing date_part utf8 argument #7846

merged 1 commit into from
Oct 17, 2023

Conversation

Dandandan
Copy link
Contributor

@Dandandan Dandandan commented Oct 17, 2023 •
edited
Loading

Which issue does this PR close?

Closes #7847

Rationale for this change

What changes are included in this PR?

Reordering the function signature to prioritize coercing to higher precision types.

Are these changes tested?

Yes, extra tests added.

Are there any user-facing changes?

@github-actions github-actions bot added logical-expr Logical plan and expressions core Core DataFusion crate labels Oct 17, 2023
joroKr21
joroKr21 approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@joroKr21 joroKr21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

Weijun-H
Weijun-H approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@Weijun-H Weijun-H left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @Dandandan

@Dandandan Dandandan merged commit d009d48 into apache:main Oct 17, 2023
24 checks passed
@andygrove andygrove added the enhancement New feature or request label Nov 5, 2023
@matthewgapp matthewgapp mentioned this pull request Jan 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fsdvh fsdvh fsdvh approved these changes

@Weijun-H Weijun-H Weijun-H approved these changes

@joroKr21 joroKr21 joroKr21 approved these changes

@viirya viirya viirya approved these changes

Assignees
No one assigned
Labels
core Core DataFusion crate enhancement New feature or request logical-expr Logical plan and expressions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Precision loss when coercing date_part utf8 argument
6 participants
@Dandandan @viirya @joroKr21 @Weijun-H @fsdvh @andygrove