-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DataSink
additions
#7778
Merged
Merged
DataSink
additions
#7778
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
cb06b89
File sink additions
Dandandan e90d645
Merge branch 'main' into file_sink_updates
Dandandan 4d853f2
Fmt
Dandandan 18bf27f
Clippy
Dandandan 8186875
Update datafusion/physical-plan/src/insert.rs
Dandandan 52ffb7e
Feedback
Dandandan eccd5c4
Feedback
Dandandan e27f8c4
Fmt
Dandandan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -35,6 +35,7 @@ use std::any::Any; | |
use std::fmt::Debug; | ||
use std::sync::Arc; | ||
|
||
use crate::metrics::MetricsSet; | ||
use crate::stream::RecordBatchStreamAdapter; | ||
use datafusion_common::{exec_err, internal_err, DataFusionError}; | ||
use datafusion_execution::TaskContext; | ||
|
@@ -46,6 +47,16 @@ use datafusion_execution::TaskContext; | |
/// output. | ||
#[async_trait] | ||
pub trait DataSink: DisplayAs + Debug + Send + Sync { | ||
/// Returns the data sink as [`Any`](std::any::Any) so that it can be | ||
/// downcast to a specific implementation. | ||
fn as_any(&self) -> &dyn Any; | ||
|
||
/// Return a snapshot of the [MetricsSet] for this | ||
/// [DataSink]. | ||
/// | ||
/// See [ExecutionPlan::metrics()] for more details | ||
fn metrics(&self) -> Option<MetricsSet>; | ||
|
||
// TODO add desired input ordering | ||
// How does this sink want its input ordered? | ||
|
||
|
@@ -151,6 +162,16 @@ impl FileSinkExec { | |
} | ||
Ok(streams) | ||
} | ||
|
||
/// Returns insert sink | ||
pub fn sink(&self) -> &dyn DataSink { | ||
self.sink.as_ref() | ||
} | ||
|
||
/// Returns the metrics of the underlying [DataSink] | ||
pub fn metrics(&self) -> Option<MetricsSet> { | ||
self.sink.metrics() | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ahh this was the wrong place, it should be in |
||
} | ||
} | ||
|
||
impl DisplayAs for FileSinkExec { | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 I wonder if there is value in making some sort of End to End example for this feature (so we don't accidentally break it in the future0