Support all the codecs supported by Avro #7718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Waiting for the PR in arrow-testing merged. |
sarutak
changed the title
alamb
added a commit
to apache/arrow-testing
that referenced
this pull request
Oct 1, 2023
This PR proposes to add xz, zstd, bzip2 and snappy variant of `alltypes_plain.avro`. This change is necessary for [this PR](apache/datafusion#7718). The contents is the same as existing `alltypes_plain.avro`. The content represented as JSON is as follows. ``` {"bigint_col":0,"bool_col":true,"date_string_col":[48,51,47,48,49,47,48,57],"double_col":0.0,"float_col":0.0,"id":4,"int_col":0,"smallint_col":0,"string_col":[48],"timestamp_col":1235865600000000,"tinyint_col":0} {"bigint_col":10,"bool_col":false,"date_string_col":[48,51,47,48,49,47,48,57],"double_col":10.1,"float_col":1.100000023841858,"id":5,"int_col":1,"smallint_col":1,"string_col":[49],"timestamp_col":1235865660000000,"tinyint_col":1} {"bigint_col":0,"bool_col":true,"date_string_col":[48,52,47,48,49,47,48,57],"double_col":0.0,"float_col":0.0,"id":6,"int_col":0,"smallint_col":0,"string_col":[48],"timestamp_col":1238544000000000,"tinyint_col":0} {"bigint_col":10,"bool_col":false,"date_string_col":[48,52,47,48,49,47,48,57],"double_col":10.1,"float_col":1.100000023841858,"id":7,"int_col":1,"smallint_col":1,"string_col":[49],"timestamp_col":1238544060000000,"tinyint_col":1} {"bigint_col":0,"bool_col":true,"date_string_col":[48,50,47,48,49,47,48,57],"double_col":0.0,"float_col":0.0,"id":2,"int_col":0,"smallint_col":0,"string_col":[48],"timestamp_col":1233446400000000,"tinyint_col":0} {"bigint_col":10,"bool_col":false,"date_string_col":[48,50,47,48,49,47,48,57],"double_col":10.1,"float_col":1.100000023841858,"id":3,"int_col":1,"smallint_col":1,"string_col":[49],"timestamp_col":1233446460000000,"tinyint_col":1} {"bigint_col":0,"bool_col":true,"date_string_col":[48,49,47,48,49,47,48,57],"double_col":0.0,"float_col":0.0,"id":0,"int_col":0,"smallint_col":0,"string_col":[48],"timestamp_col":1230768000000000,"tinyint_col":0} {"bigint_col":10,"bool_col":false,"date_string_col":[48,49,47,48,49,47,48,57],"double_col":10.1,"float_col":1.100000023841858,"id":1,"int_col":1,"smallint_col":1,"string_col":[49],"timestamp_col":1230768060000000,"tinyint_col":1} ```
viirya
approved these changes
Oct 1, 2023
Dandandan
approved these changes
Oct 2, 2023
Ted-Jiang
pushed a commit
to Ted-Jiang/arrow-datafusion
that referenced
this pull request
Oct 7, 2023
* Support all the codes supported by Avro * Update testing dir
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #7717
Rationale for this change
Avro supports deflate, snappy, bzip2, xz and zstandard but currently Datafusion only enables snappy.
What changes are included in this PR?
Change
common/Cargo.tomlto enable the codecs supported by Avro.Are these changes tested?
Added new tests.
Are there any user-facing changes?
Yes. But this change doesn't break compatibility.