Extend infer_placeholder_types to support BETWEEN predicates #7703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @andrelmartins -- this looks like a nice improvement to me ❤️ -- I kicked off the CI jobs |
|
CI was failing due to #7705. I think if you merge the branch up from main the CI will pass. Thanks again @andrelmartins |
alamb
approved these changes
Oct 1, 2023
There was a problem hiding this comment.
Thank you again @andrelmartins -- we have resolved the CI failure on main, so I think this PR is good to go.
Ted-Jiang
pushed a commit
to Ted-Jiang/arrow-datafusion
that referenced
this pull request
Oct 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #7702.
Rationale for this change
What changes are included in this PR?
Add extra inference code for BETWEEN predicate.
Are these changes tested?
Unit test in code.
Are there any user-facing changes?
Parameter type inference now works with statements like
SELECT ... WHERE col BETWEEN $1 AND $2.