correctly build nullability information in values exec #7694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
reviewed
Sep 29, 2023
| @@ -54,7 +55,16 @@ impl ValuesExec { | |||
| let n_col = schema.fields().len(); | |||
| // we have this single row, null, typed batch as a placeholder to satisfy evaluation argument | |||
| let batch = RecordBatch::try_new( | |||
| schema.clone(), | |||
| // the schema we're using might have non-nullable fields, so we need to make them nullable | |||
There was a problem hiding this comment.
Given the issue appears to be that the schema in the MemoryTable doesn't match the schema of all its batches, what would you think about making this change in MemoryTable insert logic itself.
For example, perhaps after insert it could replace all batches with its own schema (perhaps also ensuring the nullability is correct).
|
Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #7693.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?