Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add exec_err! error macro #7361

Merged
merged 5 commits into from
Aug 23, 2023
Merged

Add exec_err! error macro #7361

merged 5 commits into from
Aug 23, 2023

Conversation

comphead
Copy link
Contributor

Which issue does this PR close?

Part of #7360.

Rationale for this change

Add exec_err! error macro to replace DatafusionError::Execution with more concise code and make error handling in single place

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added sql SQL Planner logical-expr Logical plan and expressions physical-expr Physical Expressions optimizer Optimizer rules core Core DataFusion crate sqllogictest SQL Logic Tests (.slt) substrait labels Aug 22, 2023
@comphead comphead mentioned this pull request Aug 22, 2023
Open
23 tasks
@comphead comphead marked this pull request as draft August 22, 2023 01:38
@comphead comphead marked this pull request as ready for review August 22, 2023 17:41
alamb
alamb approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As always, thank you for your contributions @comphead -- this looks like a great continued improvement and I will merge it in to avoid accumulating conflicts

@alamb alamb merged commit 46cdb8c into apache:main Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
core Core DataFusion crate logical-expr Logical plan and expressions optimizer Optimizer rules physical-expr Physical Expressions sql SQL Planner sqllogictest SQL Logic Tests (.slt) substrait
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@comphead @alamb