Deprecate ScalarValue bitor, bitand, and bitxor (#6842) #7351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
commented
Aug 21, 2023
| Some(distinct_values), | ||
| self.data_type.clone(), | ||
| )] | ||
| .map(|x| ScalarValue::new_primitive::<T>(Some(*x), &T::DATA_TYPE)) |
There was a problem hiding this comment.
This is pretty gross, it occurs to me that ScalarValue not storing ArrayRef is pretty strange
There was a problem hiding this comment.
👍 I think this came up in a discussion before (distinct count I think).
tustvold
commented
Aug 21, 2023
| /// # Panics | ||
| /// | ||
| /// Panics if d is not compatible with T | ||
| pub fn new_primitive<T: ArrowPrimitiveType>( |
There was a problem hiding this comment.
This is the sort of thing that becomes so much simpler with #7353
Dandandan
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #6842
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?