Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support make_array null handling in nested version #7207

Merged
merged 4 commits into from
Aug 8, 2023

Conversation

jayzhan211
Copy link
Contributor

Which issue does this PR close?

Closes #7136.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added physical-expr Physical Expressions optimizer Optimizer rules core Core DataFusion crate sqllogictest SQL Logic Tests (.slt) labels Aug 5, 2023
Signed-off-by: jayzhan211 <[email protected]>
Signed-off-by: jayzhan211 <[email protected]>
@github-actions github-actions bot removed the optimizer Optimizer rules label Aug 5, 2023
@jayzhan211 jayzhan211 marked this pull request as draft August 5, 2023 13:07
@jayzhan211 jayzhan211 marked this pull request as ready for review August 5, 2023 13:34
@jayzhan211
Copy link
Contributor Author

jayzhan211 commented Aug 5, 2023

@izveigor @alamb Ready for review, thanks.

@jayzhan211 jayzhan211 marked this pull request as draft August 5, 2023 15:05
@jayzhan211 jayzhan211 marked this pull request as ready for review August 6, 2023 10:32
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like an improvement to me -- thank you @jayzhan211

Any concerns about merging this @izveigor ?

Copy link
Contributor

@izveigor izveigor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you, @jayzhan211!

@alamb alamb merged commit 01352a0 into apache:main Aug 8, 2023
@alamb
Copy link
Contributor

alamb commented Aug 8, 2023

Thanks @izveigor and @jayzhan211 !

@jayzhan211 jayzhan211 deleted the 7136 branch August 10, 2023 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate physical-expr Physical Expressions sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make_array null handling with nested version
3 participants