Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tokio only if running from a multi-thread tokio context #7205

Merged
merged 2 commits into from
Aug 6, 2023

Conversation

viirya
Copy link
Member

@viirya viirya commented Aug 5, 2023

Which issue does this PR close?

Closes #7206.

Rationale for this change

What changes are included in this PR?

spawn_buffered function will use tokio context to spawn the execution of stream if tokio runtime is started. However, if the started runtime is current-thread and it is blocked on, spawned tasks could be possibly dead-locked.

Are these changes tested?

Manually tested in internal code if using current-thread tokio runtime.

Are there any user-facing changes?

@github-actions github-actions bot added the core Core DataFusion crate label Aug 5, 2023
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This improvement makes sense to me. Thank you @viirya

I looked into where this code was used and it is part of sort / merge in case anyone else is interested:

https://github.com/search?q=repo%3Aapache%2Farrow-datafusion%20spawn_buffered&type=code

I don't understand why this change would prevent a deadlock, though 🤔 I would have thought it was related to using blocking I/O in the sort

https://github.com/apache/arrow-datafusion/blob/2d91917bb66542a44c31b7a306512bb4e09b5298/datafusion/core/src/physical_plan/sorts/sort.rs#L550-L579

Maybe we should use async IO in the sort 🤔

@viirya
Copy link
Member Author

viirya commented Aug 5, 2023

I don't understand why this change would prevent a deadlock, though 🤔 I would have thought it was related to using blocking I/O in the sort

I have used a current-thread tokio runtime to execution a query plan which contains Sort operator so it spawns sort tasks in the end. As the current thread is blocked on the query itself, spawned tasks are waiting for thread but never get it possibly because the query waits for spawned tasks too.

I think the issue I encountered is less related to IO here but more related to the tokio runtime.

So this change is to prevent such case.

@viirya viirya merged commit 3bda91a into apache:main Aug 6, 2023
@viirya
Copy link
Member Author

viirya commented Aug 6, 2023

Merged. Thanks @alamb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spawn_buffered will be dead-locked under current-thread tokio runtime
2 participants